Pass ref_time_value to epix_slide for functions and formulas
#313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Arg names still under discussion. |
nmdefries
commented
May 15, 2023
nmdefries
commented
May 19, 2023
brookslogan
requested changes
May 26, 2023
There was a problem hiding this comment.
Looks really good overall! Thanks for the attention to clear docs, being careful about corrupting environments, and attribution. The attribution part I'm also not clear on, but I've added my thoughts/exploration above. Also I've suggested a few minor wording/naming/etc. tweaks.
Co-authored-by: brookslogan <[email protected]>
Co-authored-by: brookslogan <[email protected]>
brookslogan
requested changes
Jun 7, 2023
brookslogan
approved these changes
Jun 9, 2023
|
Let's see if merging this will auto-adjust the base branches of the dependent PRs or if it's going to close them... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #170 for
epix_slidecomputation for functions and formulascomp_valuecalculation incomp_one_grppassesref_time_valuetof.rlang::as_functionthat creates functions with three args to support use ofref_time_valuein formulas. Rename args in tests and examples to establish new standard.check_sufficient_f_argsto take a # of args arg. Untilepi_slidealso passesref_time_valueto user computations, it andepix_slidewill expect different numbers of arguments from and pass different numbers of arguments to user functionf.finslidedefinitions to NOT say that any particular arg names are required when passing f computation as a function.