Attribute code borrowed/modified from rlang for use in as_slide_computation
#338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmdefries
commented
Jun 29, 2023
brookslogan
requested changes
Jul 22, 2023
brookslogan
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Looks good. Facing a new GitHub (default?) option of rebase+merge the PR rather than merge. Do you have experience with / viewpoints on this option? I don't know if it's going to drop key context like what PR the commits are associated with; otherwise it might be nice to enable easier interactive rebases if we need to do them in the future.
|
I missed that this was merging to a feature branch; maybe that's why GitHub's saying rebase+merge. I'll leave it to you to press the button whichever way. But if you think rebase should/shouldn't be the way we do things on main please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
rlangauthors and copyright holder to DESCRIPTION file. Add COPYRIGHT file. Addrlanglicense text to the documentation foras_slide_computation, noting aspects of the original code that were kept and changed.Fixes
Partially addresses #327