-
Notifications
You must be signed in to change notification settings - Fork 8
fix: manually do smoothing in jhu_csse_daily_subset, regenerate #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rda looks like it's probably good, but it doesn't match what's generated by the current R script on this branch. I think you can probably just back out the changes to the R script and we're good because I think the API's remaining errors are only in older as_of data, not latest data.
but also
-
todo: "fix doc bug to note that Delphi did 7dav-ing"[this has been long-resolved?] -
If you think the backing out changes thing works, then just addressing that last TODO is probably all that's left. If you think the
epi_slide
approach is needed, then I think re-review would be good to get another sanity check.
Also
|
a8f049e
to
1029099
Compare
not sure what "fix doc bug to note that Delphi did 7dav-ing" means. where in the docs? sounds good, i backed out my changes, moved lines around in generation file, and regenerated. |
Data set docs are in |
f01e9ee
to
bafab46
Compare
closes #251
changes
note that
archive_cases_dv_subset.R
also uses the unreliableconfirmed_7dav_incidence_prop
data, but it gets the full archive of data and fixing that is much harder.