Code

Slide improvements pass#477

Code

Merged

dshemetov merged 115 commits intodevcmu-delphi/epiprocess:devfrom

lcb/slide-improvements-2024-06cmu-delphi/epiprocess:lcb/slide-improvements-2024-06Copy head branch name to clipboard

Sep 27, 2024

Commits

Commits on Jun 12, 2024

• Clean up unused assignment

  brookslogan

  committed
  775c0fc

  Copy full SHA for 775c0fc

Commits on Jun 19, 2024

• fix(epix_slide): don't serialize object in error message

  Show description for 3d4e498
  brookslogan

  committed
  3d4e498

  Copy full SHA for 3d4e498

Commits on Jun 22, 2024

• Mention trailing commas as possible cause of slide ... error

  brookslogan

  committed
  e0188ce

  Copy full SHA for e0188ce

Commits on Jun 26, 2024

• WIP (to rebase): match data-masking outputs, deprecate competing parms

  brookslogan

  committed
  607e8e7

  Copy full SHA for 607e8e7

• docs: document (GHA)

  brookslogan

  committed
  0f876c3

  Copy full SHA for 0f876c3

• style: styler (GHA)

  brookslogan

  committed
  7a62004

  Copy full SHA for 7a62004

• as_slide_computation doesn't take new_col_name in this iteration

  brookslogan

  committed
  b2e4e61

  Copy full SHA for b2e4e61

• Fix some of the failing epi_slide tests

  Show description for 0a433dc
  brookslogan

  committed
  0a433dc

  Copy full SHA for 0a433dc

Commits on Jun 27, 2024

• Update remaining epi_slide tests

  brookslogan

  committed
  3ee20e8

  Copy full SHA for 3ee20e8

• style: styler (GHA)

  brookslogan

  committed
  d69c5af

  Copy full SHA for d69c5af

Commits on Jul 1, 2024

• Shift to new computation output format scheme in epix_slide()

  brookslogan

  committed
  02211a4

  Copy full SHA for 02211a4

• docs: document (GHA)

  brookslogan

  committed
  127c1f1

  Copy full SHA for 127c1f1

Commits on Jul 30, 2024

• Fix and update comp_value validation

  Show description for c17b67e
  brookslogan

  committed
  c17b67e

  Copy full SHA for c17b67e

• style: styler (GHA)

  brookslogan

  committed
  0fa282a

  Copy full SHA for 0fa282a

• Fix `as_tibble` on grouped `epi_df`s w/ current `tsibble` version

  brookslogan

  committed
  b128abb

  Copy full SHA for b128abb

• Fix tidyeval unnamed tibble names access errors

  brookslogan

  committed
  8d7ea7d

  Copy full SHA for 8d7ea7d

• Update archive slide tests using deprecated features

  brookslogan

  committed
  c66ef54

  Copy full SHA for c66ef54

• Actually allow multiple quosures to be passed into `epi_slide`

  brookslogan

  committed
  30a2166

  Copy full SHA for 30a2166

• Update `epi_slide` tests with expanded data-masking support

  brookslogan

  committed
  e9b1b1b

  Copy full SHA for e9b1b1b

• Avoid warning in slides on `binding = NULL` if binding doesn't exist

  Show description for 9b73649
  brookslogan

  committed
  9b73649

  Copy full SHA for 9b73649

• Make advanced slide tidyeval tests realistically work around recycling

  brookslogan

  committed
  a1c7020

  Copy full SHA for a1c7020

• Test that epi_slide balks at bad computation outputs

  brookslogan

  committed
  ec77184

  Copy full SHA for ec77184

Commits on Jul 31, 2024

• Merge remote-tracking branch 'upstream/dev' into lcb/slide-improvements-2024-06

  brookslogan

  committed
  7b5bd4e

  Copy full SHA for 7b5bd4e

• Document new slide tidyeval features

  brookslogan

  committed
  e089d42

  Copy full SHA for e089d42

• docs: more on tidyeval features, as_list_col + names_sep deprecations

  Show description for 4027f06
  brookslogan

  committed
  4027f06

  Copy full SHA for 4027f06

Commits on Aug 2, 2024

• Check deprecations earlier in fns, correct the `when` args

  brookslogan

  committed
  2160921

  Copy full SHA for 2160921

• Fix tidyeval breaking on dot-prefixed column names

  brookslogan

  committed
  90b7e2f

  Copy full SHA for 90b7e2f

• fix: Actually complete workaround for tsibble:::as_tibble.grouped_df

  brookslogan

  committed
  1f410fc

  Copy full SHA for 1f410fc

• refactor(slide.R): move slide_one_grp definition after input munging

  brookslogan

  committed
  512c6ba

  Copy full SHA for 512c6ba

• Fix deprecations referring to wrong functions

  brookslogan

  committed
  ba536cd

  Copy full SHA for ba536cd

• refactor(epix_slide): don't double-convert tidyeval + better code ordering

  brookslogan

  committed
  00c0d85

  Copy full SHA for 00c0d85

• Soften as_list_col and names_sep deprecations

  brookslogan

  committed
  70e86a3

  Copy full SHA for 70e86a3

• Fix some deprecation message naming and details

  brookslogan

  committed
  5452bba

  Copy full SHA for 5452bba

• Fix softer deprecation of epi[x]_slide(<nm> = <df>, as_list_col = TRUE)

  brookslogan

  committed
  dfb249a

  Copy full SHA for dfb249a

• fix(epi[x]_slide): again, don't reject (row)named data frames

  Show description for 7a7e781
  brookslogan

  committed
  7a7e781

  Copy full SHA for 7a7e781

Commits on Aug 3, 2024

• docs(epi[x]_slide): update NEWS.md, vignettes for breaking changes

  brookslogan

  committed
  418a65a

  Copy full SHA for 418a65a

Commits on Aug 5, 2024

• Linting, nolinting, and nonolinting

  brookslogan

  committed
  0d794c6

  Copy full SHA for 0d794c6

Commits on Aug 15, 2024

• refactor: explain how tidyeval column redefinition actually works out

  brookslogan

  committed
  f53f331

  Copy full SHA for f53f331

Commits on Aug 21, 2024

• refactor(epi[x]_slide): rearrange new_col_name logic branches

  Show description for 5cfa121
  brookslogan

  committed
  5cfa121

  Copy full SHA for 5cfa121

• tests: refactor a few slide tests (#516)

  Show description for 7277b81
  dshemetov

  authored
  7277b81

  Copy full SHA for 7277b81

• Merge branch 'dev' into lcb/slide-improvements-2024-06

  dshemetov

  committed
  4496512

  Copy full SHA for 4496512

• docs: document (GHA)

  dshemetov

  committed
  4fe94da

  Copy full SHA for 4fe94da

• tests: enable parallel tests

  dshemetov

  committed
  6b7944e

  Copy full SHA for 6b7944e

• tests: fix a few tests

  dshemetov

  committed
  6a70274

  Copy full SHA for 6a70274

• docs: document (GHA)

  dshemetov

  committed
  902bf61

  Copy full SHA for 902bf61

• Fix misfiled NEWS.md entry, combine two breaking changes sections

  brookslogan

  committed
  0faa438

  Copy full SHA for 0faa438

Commits on Aug 22, 2024

• tests: even more slide test consolidation

  dshemetov

  committed
  d88ec2d

  Copy full SHA for d88ec2d

• doc: document

  dshemetov

  committed
  4553b89

  Copy full SHA for 4553b89

• tests: even more slide test refactors

  dshemetov

  committed
  971da03

  Copy full SHA for 971da03

• lint: lint

  dshemetov

  committed
  871946f

  Copy full SHA for 871946f

Commits on Aug 23, 2024

• wip: rework slide window args (#513)

  Show description for de948b5
  dshemetov

  authored
  de948b5

  Copy full SHA for de948b5

• lint: lint

  dshemetov

  committed
  b393491

  Copy full SHA for b393491

• doc: doc

  dshemetov

  committed
  9c4c49d

  Copy full SHA for 9c4c49d

• feat: other_keys as arg in epi_df, epi_archive (#512)

  Show description for 57cda93
  

  3 peopleauthored
  57cda93

  Copy full SHA for 57cda93

• docs: version and news

  dshemetov

  committed
  f479acf

  Copy full SHA for f479acf

• refactor!: hard deprecate names_sep and as_list_col in epix_slide

  dshemetov

  committed
  2382af0

  Copy full SHA for 2382af0

• doc: doc

  dshemetov

  committed
  5f9ffc8

  Copy full SHA for 5f9ffc8

• refactor: dot prefix epix_slide args as well

  dshemetov

  committed
  2c043d5

  Copy full SHA for 2c043d5

Commits on Aug 24, 2024

• doc: improve the .f documentation for epi_slide and epix_slide

  dshemetov

  committed
  c0f6499

  Copy full SHA for c0f6499

• doc: switch centre to center

  dshemetov

  committed
  2f91a90

  Copy full SHA for 2f91a90

Commits on Aug 26, 2024

• tests(assert_sufficient_f_args): test vs. mean, sum, slice; use expect_no*

  brookslogan

  committed
  9f33e1b

  Copy full SHA for 9f33e1b

• BREAKING CHANGE(epix_slide): output `version` column, other re/dual-names

  Show description for 14cd736
  brookslogan

  committed
  14cd736

  Copy full SHA for 14cd736

• Fix vignette re. old clobberable version default + use versions_end

  Show description for 3110a7f
  brookslogan

  committed
  3110a7f

  Copy full SHA for 3110a7f

• Rename max_version -> version in epix_as_of

  Show description for aa73944
  brookslogan

  committed
  aa73944

  Copy full SHA for aa73944

• fix(epix_slide): partial time_value -> version output col rename

  brookslogan

  committed
  547d156

  Copy full SHA for 547d156

• Add group_vars.grouped_epi_archive

  brookslogan

  committed
  4290363

  Copy full SHA for 4290363

• refactor+tweak: add+use `format_class_vec` helper for messages

  Show description for 4b112e5
  brookslogan

  committed
  4b112e5

  Copy full SHA for 4b112e5

• WIP Add docs for de-dupe approach, part of the required validation

  Show description for 8838c71
  brookslogan

  committed
  8838c71

  Copy full SHA for 8838c71

• Style and fix&improve some .new_col_name validation

  brookslogan

  committed
  9127952

  Copy full SHA for 9127952

• style: styler (GHA)

  brookslogan

  committed
  7af57cc

  Copy full SHA for 7af57cc

Commits on Aug 29, 2024

• Fix slide rebase issues, other partial renames, dotprefix internalfn

  Show description for 1181b97
  brookslogan

  committed
  1181b97

  Copy full SHA for 1181b97

Commits on Sep 4, 2024

• Dot-prefix more args, locals; finish some incomplete renames

  Show description for 1ae0ef5
  brookslogan

  committed
  1ae0ef5

  Copy full SHA for 1ae0ef5

• docs: document (GHA)

  brookslogan

  committed
  6854c07

  Copy full SHA for 6854c07

• Dot-prefix `f` args in helper functions (& their messages)

  brookslogan

  committed
  ef2639e

  Copy full SHA for ef2639e

• WIP output column de-duping in epix_slide

  brookslogan

  committed
  9aafabb

  Copy full SHA for 9aafabb

• style: styler (GHA)

  brookslogan

  committed
  e463714

  Copy full SHA for e463714

Commits on Sep 5, 2024

• Add missing dot prefixes in some messages

  brookslogan

  committed
  8973edd

  Copy full SHA for 8973edd

• Fix empty-version grouped slide behavior change, tweak warning

  Show description for e039a40
  brookslogan

  committed
  e039a40

  Copy full SHA for e039a40

Commits on Sep 6, 2024

• feat: refactor epi_slide

  Show description for dd5c769
  dshemetov

  committed
  dd5c769

  Copy full SHA for dd5c769

Commits on Sep 10, 2024

• Fix typo

  brookslogan

  committed
  4444a6c

  Copy full SHA for 4444a6c

Commits on Sep 12, 2024

• Allow dupe & dedupe cols in epi_slide; needs&helps future .keep=TRUE

  Show description for b2dfa09
  brookslogan

  committed
  b2dfa09

  Copy full SHA for b2dfa09

• style: styler (GHA)

  brookslogan

  committed
  9b4f10a

  Copy full SHA for 9b4f10a

• Move to .keep = TRUE in `epi_slide` + fix other dedupe issues

  brookslogan

  committed
  a110a42

  Copy full SHA for a110a42

• fix: aggregate is now sum_groups_epi_df and other review changes

  Show description for dfd49f5
  

  dshemetov

  and

  brookslogan

  committed
  dfd49f5

  Copy full SHA for dfd49f5

Commits on Sep 13, 2024

• Correct commentary regarding slide output type edge cases

  brookslogan

  committed
  53005ff

  Copy full SHA for 53005ff

• feat(epi_slide): catch common operations x forgotten colname

  Show description for e1d300d
  brookslogan

  committed
  e1d300d

  Copy full SHA for e1d300d

• Test epi_df forbidden methods + fix error message

  brookslogan

  committed
  129ad9f

  Copy full SHA for 129ad9f

• style: styler (GHA)

  brookslogan

  committed
  fd04433

  Copy full SHA for fd04433

• Use `cnd_class = TRUE` when snapshot is primary test

  brookslogan

  committed
  16cf8d7

  Copy full SHA for 16cf8d7

• improve is null or na

  dshemetov

  committed
  8eca321

  Copy full SHA for 8eca321

Commits on Sep 16, 2024

• Merge pull request #521 from cmu-delphi/lcb/slide-unnest-dedupe-cols

  brookslogan

  authored
  9ab9731

  Copy full SHA for 9ab9731

• refactor: move group_epi_df

  dshemetov

  committed
  b1ab47d

  Copy full SHA for b1ab47d

• refactor: add arrange_[col/row]_canonical

  dshemetov

  committed
  6b93d79

  Copy full SHA for 6b93d79

Commits on Sep 17, 2024

• refactor: improve and slim down epi_slide tests

  dshemetov

  committed
  926f845

  Copy full SHA for 926f845

• lint: line breaks

  dshemetov

  committed
  c167ddf

  Copy full SHA for c167ddf

• Merge branch 'lcb/slide-improvements-2024-06' into ds/epi-slide-group

  dshemetov

  committed
  cccd6e3

  Copy full SHA for cccd6e3

• fix: leftover merge issue and test fix

  dshemetov

  committed
  f1abe17

  Copy full SHA for f1abe17

• docs: document (GHA)

  dshemetov

  committed
  409dcac

  Copy full SHA for 409dcac

Commits on Sep 18, 2024

• Merge pull request #519 from cmu-delphi/ds/epi-slide-group

  Show description for 214100d
  dshemetov

  authored
  214100d

  Copy full SHA for 214100d

• Better detection, messaging, docs on epi_slide output clashes

  Show description for d2372f0
  brookslogan

  committed
  d2372f0

  Copy full SHA for d2372f0

• Fix partial rename

  brookslogan

  committed
  166b8c3

  Copy full SHA for 166b8c3

• lint: lint

  dshemetov

  committed
  82047a4

  Copy full SHA for 82047a4

Commits on Sep 19, 2024

• Make format_tibble_row look better on time classes

  Show description for 46af707
  brookslogan

  committed
  46af707

  Copy full SHA for 46af707

• Improve slide output column conflict messages

  brookslogan

  committed
  177e7cc

  Copy full SHA for 177e7cc

• Fix data$ typo, avoid `.data$` in tidyselections

  Show description for bde98ec
  brookslogan

  committed
  bde98ec

  Copy full SHA for bde98ec

• lint: more lint

  dshemetov

  committed
  48735c5

  Copy full SHA for 48735c5

• fix: .ref_time_values -> .versions in epix_slide and some doc fixes

  dshemetov

  committed
  227e133

  Copy full SHA for 227e133

• docs: document (GHA)

  dshemetov

  committed
  0eba732

  Copy full SHA for 0eba732

• fix: fix the fix

  dshemetov

  committed
  61de9ec

  Copy full SHA for 61de9ec

Commits on Sep 20, 2024

• Also check for `slide_value` name conflict in `epix_slide`

  brookslogan

  committed
  25aa1b2

  Copy full SHA for 25aa1b2

• Remove todo comment suggesting bad path

  brookslogan

  committed
  4f8e8d5

  Copy full SHA for 4f8e8d5

• Add some epix_slide output col dedupe tests

  brookslogan

  committed
  d2dc2bf

  Copy full SHA for d2dc2bf

• style: styler (GHA)

  brookslogan

  committed
  dd19428

  Copy full SHA for dd19428

Commits on Sep 26, 2024

• refactor+doc: key_colnames and vignettes

  Show description for 8202c0e
  dshemetov

  committed
  8202c0e

  Copy full SHA for 8202c0e

• doc: update NEWS

  dshemetov

  committed
  187bd5d

  Copy full SHA for 187bd5d