Add complete.epi_df
method so grouped completions don't drop epi_df…
#488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ness
Requesting review from @dshemetov since we talked about S3 stuff recently + to point at #391 where David's already done some of the work we were talking about. @nmdefries I'm not sure this really needs 2 people to review, but GitHub's not letting me unrequest.
[Actually this isn't ready for review yet. I should rebase on top of the time type changes and re-run tests first. And test the time type reinference.]
Checklist
Please:
PR).
brookslogan, nmdefries.
DESCRIPTION
. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
process.
Change explanations for reviewer
Adds a
complete.epi_df
method that doesn't drop epi_dfness when grouped.Too much context:
We've had to basically always recommend
complete()
ing before putting things into anepi_df
, because of various things that could go wrong down the line. Whileepi_slide_opt()
avoids bad behaviors when running on uncomplete()
d data, we still aren't free: there is still cmu-delphi/epipredict#362 to avoid and complete()ion for other purposes, such as sliding functionsepi_slide_opt()
doesn't handle (andepi_slide()
does bad things on), filling with 0s, makingdplyr::lag
actually work, naturally, maybe fixing some other 3rd-party library stuff, and standardizing time availability across epikeys (though we probably actually work for that last case already).Grouped completions drop
epi_df
ness; it's annoying to have to carefully place thecomplete()
beforeas_epi_df()
when tweakingepi_df
construction (especially if using the newas_epi_df
renaming conveniences where you need to remember what the old names were when writing thecomplete()
), and even more annoying/error-inducing to try to convert back to anepi_df
after losingepi_df
ness (since it's easy to forget and annoying to provide metadata).Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch