-
Notifications
You must be signed in to change notification settings - Fork 8
refactor: remove Suggests dependence on covidcast #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* just download the files, don't import covidcast * covidcast depends on sf which is tough to install
Makes sense. Should probably be solved upstream in this case cmu-delphi/epidatasets#7 |
|
It's basically a one line change to the epidatasets scripts, it's not bad |
* Rename state_census -> state_naming. * Provide col_types specs for all & only columns used; avoid message spam. * Don't select unused cols; especially avoid the numeric state FIPS. * Bump dependency on dplyr and update joins; avoid message spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this is good to go. Going to force-push to try to make some checks happen.
Checklist
Please:
PR).
brookslogan, nmdefries.
DESCRIPTION
. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
process.
Change explanations for reviewer
Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch