Skip to content

Improve epi_slide_{sum,mean} unsupported-arg messages. #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

brookslogan
Copy link
Contributor

@brookslogan brookslogan commented Dec 10, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • [-] Request a review from one of the current main reviewers:
    brookslogan, nmdefries.
  • [-] Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
    • Skipping bumping as this is so near 0.10.0 release PRs.
  • [-] Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).
    • should already be covered by the the epi_slide_opt change description
  • See DEVELOPMENT.md for more information on the development
    process.

Change explanations for reviewer

  • Also fixes lack of document() from accidental direct push. Branch protection settings have been updated to try to prevent.

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

@brookslogan brookslogan mentioned this pull request Dec 10, 2024
1 task
@brookslogan brookslogan merged commit e5ec121 into dev Dec 10, 2024
5 checks passed
@brookslogan brookslogan deleted the lcb/fix-slide-opt-validation branch December 10, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix check & better epi_slide_mean(new_col_name =) error message
1 participant