Conversation
| @@ -0,0 +1 @@ | |||
| 21 | |||
There was a problem hiding this comment.
The current Node version for Netlify (deploy preview).
melange396
left a comment
melange396
left a comment
There was a problem hiding this comment.
Lots of version bumps in package.json! Did you update all those with some tool or by hand? If the latter, are they all just set to the most recent version (as of the time the change was made, at least)?
| constructor( | ||
| public readonly title: string, | ||
| public readonly datasets: (DataSet | DataGroup)[], | ||
| ) {} |
There was a problem hiding this comment.
this looks like just whitespace changes... if so, we should exclude this file from the PR.
| constructor( | ||
| private readonly year: number, | ||
| private readonly month: number, | ||
| private readonly day: number, | ||
| ) { |
There was a problem hiding this comment.
this looks like just whitespace changes... if so, we should exclude this file from the PR.
| constructor( | ||
| private readonly date: EpiDate, | ||
| private readonly value: number, | ||
| ) {} |
There was a problem hiding this comment.
this looks like just whitespace changes... if so, we should exclude this file from the PR.
| <span | ||
| on:click={toggleExpanded} | ||
| role="button" | ||
| tabindex="0" | ||
| on:keydown={(e) => { | ||
| if (e.key !== 'Enter' && e.key !== ' ') return; | ||
| e.preventDefault(); | ||
| if (e.target != null) { | ||
| e.target.click(); | ||
| } | ||
| }} | ||
| > |
There was a problem hiding this comment.
whats the purpose of this? it looks like an addition in functionality to allow keyboard interaction with the leftmost panel (signal legend), and not a compatibility migration.
| role="button" | ||
| tabindex="0" | ||
| on:keydown={(e) => { | ||
| if (e.key !== 'Enter' && e.key !== ' ') return; | ||
| e.preventDefault(); | ||
| if (e.target != null) { | ||
| e.target.click(); | ||
| } | ||
| }} |
There was a problem hiding this comment.
whats the purpose of this? it looks like an addition in functionality to allow keyboard interaction with the leftmost panel (signal legend), and not a compatibility migration.
| #!/bin/sh | ||
| . "$(dirname "$0")/_/husky.sh" |
There was a problem hiding this comment.
for posterity, this is removed by/in husky v9.1.1 : typicode/husky#1472 (comment)
| "compilerOptions": { | ||
| "module": "ES2020", | ||
| "lib": ["ES2019", "DOM"], | ||
| "importsNotUsedAsValues": "error", |
There was a problem hiding this comment.
for posterity, this is a typescript 5 change: https://stackoverflow.com/questions/75449286/how-to-fix-flag-importsnotusedasvalues-is-deprecated-and-will-stop-functionin
see also addition of the following line below:
"verbatimModuleSyntax": true
|
@melange396 answering all of these at once!
|
2 participants
This PR updates the Svelte version used in the project to the stable 4.2.19. It also updates the majority of the project's dependencies to match this new version, with the exceptions being its build tools (rollup & eslint).
It is intended as a prerequisite to #73 and should not be merged until said test suite is finished.