Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages. #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DavidEGrayson
Copy link
Contributor

@DavidEGrayson DavidEGrayson commented Dec 9, 2024

I got kind of confused by the error messages printed by the Haversine profiler, and had to dig into the code to understand what I did wrong. This PR makes the process smoother for the next person having similar trouble:

  • Usage message now explains both args, and does not use square brackets for non-optional args.
  • Only say that the test data is empty if it actually is. (My answers file was the wrong size, and that triggered the misleading "Test data size must be non-zero." error.)
  • Use the word "Average" instead of "Sum" in most places to describe the number computed by adding the distances together and dividing by the number of them.

- Usage message now explains both args, and does not use square brackets
  for non-optional args.
- Only say that the test data is empty if it actually is.
  (My answers file was the wrong size, and that triggered the misleading
  "Test data size must be non-zero." error.)
- Use the word "Average" instead of "Sum" in most places to describe the
  number computed by adding the distances together and dividing by the
  number of them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant