test-failure-policy: Ignore window. prefix for ph_* test helper functions
#6688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions We will soon move cockpit's test-functions.js helpers to the `window` object, so that they become compatible with Webdriver's script preloading API. This affects all naughty patterns which include any of the `ph_*()` function calls (i.e. most patterns). Until this all lands and settles down, avoid mass-changing all the patterns and just remove the `window.` prefix for the comparison. Note that the naughties also apply to old project branches.
jelly
approved these changes
Aug 2, 2024
|
This run shows that naughties with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will soon move cockpit's test-functions.js helpers to the
windowobject, so that they become compatible with Webdriver's script preloading API. This affects all naughty patterns which include any of theph_*()function calls (i.e. most patterns). Until this all lands and settles down, avoid mass-changing all the patterns and just remove thewindow.prefix for the comparison.Note that the naughties also apply to old project branches.
I tested locally that this works. Once this lands, I'll send a cockpit PR to actually do that move -- it's intrusive but simple, and I want it out of the way. Then cockpit-project/cockpit#20832 should become much greener.