Makefile: bring back the -node.tar.xz artifact #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial revert of e64ce8d. It's Fedora policy that we run esbuild during the rpm phase, so let's bring back the tarball with the things required to do that and include it in the packaging again. We need to add a bit of a hack here: when we create the tarball we set all timestamps to the same value. If `dist/` is missing, then we make sure `package-lock.json` is up to date before trying to run esbuild, but since all timestamps are the same, `make` will conclude that it needs to be rebuilt. In turn, that calls `tools/node-modules`, which gets upset because it's not in a git checkout. We can short-circuit that by touching `package-lock.json` when we delete `dist/`.
martinpitt
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
If that goes green, fine for me -- it's the trodden path and avoids getting stuck in review. Thanks!
If/when you land, please squash and edit in the "Fixes #508"
|
rpm build log LGTM. It rebuilt dist/. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial revert of e64ce8d.
It's Fedora policy that we run esbuild during the rpm phase, so let's bring back the tarball with the things required to do that and include it in the packaging again.
We need to add a bit of a hack here: when we create the tarball we set all timestamps to the same value. If
dist/is missing, then we make surepackage-lock.jsonis up to date before trying to run esbuild, but since all timestamps are the same,makewill conclude that it needs to be rebuilt. In turn, that callstools/node-modules, which gets upset because it's not in a git checkout. We can short-circuit that by touchingpackage-lock.jsonwhen we deletedist/.