test: Fix empty dir check in testPermissions #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When opening an empty dir, we expect the "Directory is empty" empty state to *appear*. Checking for its absence is a race condition. Additionally verify that the breadcrumb shows the expected directory. Drop the redundant wait_visible() before the click.
6 tasks
tomasmatus
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening an empty dir, we expect the "Directory is empty" empty state to appear. Checking for its absence is a race condition. Additionally verify that the breadcrumb shows the expected directory.
Drop the redundant wait_visible() before the click.
I ran into this in #917 all the time, and it's also very prominent on the weather report: