test: Fix empty dir check in testUpload #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to commit b045f17, this test changes into an empty (except for 3 hidden files) directory. So wait for that. This fixes a race condition where the test would only succeed if the empty state wasn't rendered too fast.
6 tasks
jelly
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to commit b045f17, this test changes into an empty (except for 3 hidden files) directory. So wait for that. This fixes a race condition where the test would only succeed if the empty state wasn't rendered too fast.
failure 1, failure 2
Spotted in #917 due to 3x affected tests.