Fix crash if <redirdev> has no <address>
#1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old existing domain definitions may have `<redirdev>` elements without any `<address>` child. It's impossible to actually create these with current libvirt, as `virsh import`ing such a definition will automatically add an address -- so we can't create a test for this. Fixes cockpit-project#1307
|
@carrowood : Please feel free to test this on your machine using the COPR build. Thanks! |
That test build solved the issue. Thanks! Now I will go clean up the root problem (that VM definition). |
jelly
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old existing domain definitions may have
<redirdev>elements without any<address>child. It's impossible to actually create these with current libvirt, asvirsh importing such a definition will automatically add an address -- so we can't create a test for this.Fixes #1307