Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add a check about disk bus if creating a VM without OS #1378

Merged
merged 1 commit into from
Jan 18, 2024
Merged

test: add a check about disk bus if creating a VM without OS #1378

merged 1 commit into from
Jan 18, 2024

Conversation

yunmingyang
Copy link
Contributor

No description provided.

@martinpitt
Copy link
Member

Thanks! But TestMachinesDisks.testDiskEdit fails everywhere now.

@yunmingyang
Copy link
Contributor Author

Let me check it, thanks a lot

@jelly
Copy link
Member

jelly commented Jan 17, 2024

Re-triggered the tests, let's see if they get green.

martinpitt
martinpitt approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Also for the f-stringification in machineslib.py.

@martinpitt martinpitt merged commit 0adf7e2 into cockpit-project:main Jan 18, 2024
26 checks passed
@yunmingyang yunmingyang deleted the testCheckBus branch January 29, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpitt martinpitt martinpitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yunmingyang @martinpitt @jelly