vendor: update to the latest systemd_ctypes #19927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonkarlitskaya
added
the
blocked
allisonkarlitskaya
force-pushed
the
update-systemd_ctypes
branch
from
c138fa4 to
876a142
Compare
|
This won't be the final version of this PR, but FTR: I support this (wrt. to RHEL also). We've sold our souls on our tests telling us where we screwed up 😁 But I'd like to ask that we do a point release after landing this, and get them into RHEL ASAP, so that we get some field testing. |
martinpitt
removed
the
blocked
allisonkarlitskaya
force-pushed
the
update-systemd_ctypes
branch
from
876a142 to
c65a6be
Compare
|
The previous draft version had two failures: aarch64 TF, which may be "randomly corrupted testbed" or some actual regression; and a weird i386 rpm build failure which doesn't look at all related to ctypes. But let's get this fully green. |
martinpitt
previously approved these changes
Feb 2, 2024
New ruff warns to stderr that the old way is deprecated. That's enough to convince test/static-code that an error is being reported. Let's move this over.
allisonkarlitskaya
force-pushed
the
update-systemd_ctypes
branch
from
c65a6be to
4857485
Compare
jelly
previously approved these changes
Feb 2, 2024
`--unix` has never been a valid command-line argument to `curl` but it was accepted for the past decade because curl contained a "partial match" feature to expand unambiguous prefixes to their full forms. This feature was recently removed[^1] and a recent upload[^2] to rawhide is causing breaks on packit. Make sure we spell out the option name in full in all of the places we use it. [^1]: curl/curl@07dd60c [^2]: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b72488cc7d
allisonkarlitskaya
force-pushed
the
update-systemd_ctypes
branch
from
4857485 to
aff5b39
Compare
Make sure we set the ->method field on ourselves fairly soon. We might need to change our "delayed response" behaviour depending on its value.
allisonkarlitskaya
force-pushed
the
update-systemd_ctypes
branch
from
aff5b39 to
e4ef893
Compare
If we call cockpit_web_response_set_method() more than once, then we leak the old value. Fix it.
When creating the CockpitWebResponse make sure we pass the method through. This was being left as NULL in all sitautions except for testcases.
This lets us clean up control flow a little bit — we don't need to let the `l` variable outlive the scope of the loop, and in the error case we can simply exit. Also: move the computation of the error message closer to where we actually send it.
The code in cockpit_web_response_error() sends a body, regardless of if the request was for GET or for HEAD. Let's fix it to only send the body on GET.
We didn't sync this in a while and there have been a lot of changes. We also have a critical bug fix included: we recently introduced a test case (in 0bb7438) which triggers a segfault in the binding layer of systemd_ctypes due to FFI call trampolines being garbage collected while they're still running. This is currently blocking downstream packaging on several non-x86_64 architectures.
allisonkarlitskaya
force-pushed
the
update-systemd_ctypes
branch
from
e4ef893 to
2a8aae2
Compare
mvollmer
approved these changes
Feb 2, 2024
|
A note about the webserver changes in this PR, for posterity: They happened because the new curl version in rawhide is strict about servers not sending any payload when HEAD was requested. The RFC says that servers MUST NOT do this, so I guess they're right? The commit that changed curl's behaviour was this one: curl/curl@d7b6ce6 (bisected locally against our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't sync this in a while and there have been a lot of changes.
We also have a critical bug fix included: we recently introduced a test case (in 0bb7438) which triggers a segfault in the binding layer of systemd_ctypes due to FFI call trampolines being garbage collected while they're still running.
This is currently blocking downstream packaging on several non-x86_64 architectures.