BiDi follow-ups #20883
Merged
BiDi follow-ups #20883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CDP API would allow calling that when the current context was a frame. But `WebdriverBidi.locate()` uses the current context and thus cannot find the iframe there. Set the current context to the toplevel first to restore the old behaviour. This fixes cockpit-ostree `OstreeCase.testPermission`.
These skips were due to limitations in the CDP support. With BiDi they
work fine.
Even with BiDi, Firefox still can't handle `eval_js("cockpit.spawn()"`
properly, so keep skipping these tests.
https://issues.redhat.com/browse/COCKPIT-1157
1 task
When calling this with `ph_in_text()` or other functions which set a custom error descriptions, the "condition did not become true" string match didn't hit, This produced much less useful error output, and also didn't match existing naughties any more (such as for cockpit-project#4915 in TestMachinesSettings.testVsock). Drop the string matching and instead rewrite the exception after the loop, which is conceptually easier and cleaner anyway.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix cockpit-project/cockpit-ostree#679 and cockpit-project/cockpit-machines#1761