lib: rewrite manifest2po in Python #21532
Conversation
jelly
added
the
no-test
pkg/lib/manifest2po
Outdated
| """ | ||
|
|
||
|
|
||
| def get_docs_strings(docs: List[Dict[str, str]]) -> Iterable[str]: |
There was a problem hiding this comment.
This looks more like a Iterable[Mapping[str, str]] but it's not so important...
pkg/lib/manifest2po
Outdated
| yield match | ||
|
|
||
|
|
||
| def get_menu_strings(menu: Dict[str, Any]) -> Iterable[str]: |
There was a problem hiding this comment.
Not crazy about the Any here and the no checking of the actual values of the things you're accessing, but I guess there's room for pragmatism here...
There was a problem hiding this comment.
So originally I targeted to 3.6, so I didn't have a typeddict, we could make this a typeddict (the original json.load return value). Thoughts?
jelly
force-pushed
the
manifest-po-python
branch
from
8d8f26d to
e3afec2
Compare
| continue | ||
|
|
||
| # Qualify the filename if necessary | ||
| full_path = args.directory / file if args.directory else file |
There was a problem hiding this comment.
This strikes me as sort of odd.... are we just doing that because we want to get the correct relative paths in the comments in the output?
There was a problem hiding this comment.
I suppose? We do:
mkdir -p po/ && \
./pkg/lib/html2po.js -d . -o po/cockpit.html.pot \
$(cd . && find pkg/ -name '*.html')
1a174a9 to
d166d42
Compare
jelly
removed
the
no-test
There was a problem hiding this comment.
Thanks! This looks good to me, and I don't really care about putting that much more effort into this. I took the liberty to close the threads which got fixed. There are some bikeshed-y ones left, not sure how much effort you and @allisonkarlitskaya still want to throw at this.
My one request: Please diff the generated .pot file between main and this PR to make sure it's identical or has only insignificant changes. Thanks!
Extracting translatable strings from manifests is easy enough to do in pure Python and removes an dependency on node_modules. The differences in the Python implementation versus the JavaScript version: - no longer relies on global state to gather the msgid's - doesn't encode duplicate filenames for the same msgid - no longer replaces @foo@ placeholders which where removed in 473db0e
jelly
force-pushed
the
manifest-po-python
branch
from
d166d42 to
f730d03
Compare
|
Triggered a full CI run as translations do get checked in our integration tests |
|
@allisonkarlitskaya you still have a 👎 finger on here, are you ok with retracting that? |
Extracting translatable strings from manifests is easy enough to do in pure Python and removes an dependency on node_modules.
The differences in the Python implementation versus the JavaScript version:
Next up would be porting
pkg/lib/html2poto Python, this would allow us to drophtml-parserfrom node_modules.