Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Don't access out-of-bounds pixels #21544

Merged

Conversation

mvollmer
Copy link
Member

We can only access data_ref and data_now after checking that the coordinates are in bounds for both.

@mvollmer mvollmer requested a review from martinpitt January 23, 2025 12:49
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Thanks!

@mvollmer
Copy link
Member Author

The failures here don't make sense to me...

We can only access data_ref and data_now after checking that the
coordinates are in bounds for both.
@mvollmer mvollmer force-pushed the test-fix-pixel-size-changes branch from 2f8963c to db9b2ad Compare January 23, 2025 14:58
@mvollmer
Copy link
Member Author

The failures here don't make sense to me...

Ah, task container changes. Rebased.

@martinpitt martinpitt merged commit 53b9468 into cockpit-project:main Jan 24, 2025
84 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants