-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
users: Add screen reader accessible column #21546
users: Add screen reader accessible column #21546
Conversation
Fun! Our current pixel test reference is correct, the separator lines properly go to the end. Triggering the f-41 tests to see if it makes any difference. I cannot reproduce the bug with Chromium 132.0.6834 (current F41 version). Nevertheless, this looks harmless/ok, so I'm fine with applying it. However, I have a question: We don't use the There are only two other similar usages:
The latter seems to be an alias according to the documentation. @Venefilyn do you know the difference between the variant with and without Thanks! |
@Venefilyn Ugh, this breaks mobile screen size quite badly -- it seems to allocate a lot of extra space for the new column and then keep it empty. This failure is also curious -- at first sight it's totally unrelated, but then again the font change doesn't feel like a flake. I've never seen that kind of flake before. So this is a typical Yak shave 😢 |
I'll take to make sure mobile view works as expected, thanks!
It could be related either way since this PR does include a CSS import. It shouldn't do anything given they are helper CSS stuff but the helper classes might be used here and there without them doing anything atm |
122bcbf
to
708ae6d
Compare
@martinpitt the failing pixel test look fine now to me if I read them correctly |
@Venefilyn Agreed, this looks reasonable. I need to run, please ask @jelly or someone else in the channel to push the pixel test. Otherwise I'll do it this evening. 👍 thanks! |
Current users page lists the users in a table together with a column for actions. However, the table header doesn't include the last actions column and instead shows the table header line ending preemptively. As we likely don't want a visibly named column for the actions this will instead visually just extend the line so it is consistent while also adding a screen reader friendly text to indicate what the column is portraying.
708ae6d
to
5606783
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed the pixel test (you need repo permissions for that -- it will come soon enough 😁 ). Thanks!
Current users page lists the users in a table together with a column for actions. However, the table header doesn't include the last actions column and instead shows the table header line ending preemptively.
As we likely don't want a visibly named column for the actions this will instead visually just extend the line so it is consistent while also adding a screen reader friendly text to indicate what the column is portraying.
This does mean we need to include
@patternfly/patternfly/patternfly-addons.css
in the PatternFly CSS import.This line seems only to occur on Chrome and not Firefox, but definitely a bug
![image](https://private-user-images.githubusercontent.com/6598829/406100326-b60143a2-951f-4875-91fa-0c6bb8224a92.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0OTI2ODYsIm5iZiI6MTczOTQ5MjM4NiwicGF0aCI6Ii82NTk4ODI5LzQwNjEwMDMyNi1iNjAxNDNhMi05NTFmLTQ4NzUtOTFmYS0wYzZiYjgyMjRhOTIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMDAxOTQ2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZGZlODQ2ZTU4NDdlMDA0YjJjNDJmN2Y2MzI1YzgxMDZiZTYyOTI3Y2RmMmVmNGI5YmY0MDBjOGY2NjcwMmRjOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.a01wl4Sd8vH9cjf2Ay855ePDBKM3xcoH3moKAQZeRO0)
PR applied:
![image](https://private-user-images.githubusercontent.com/6598829/406098733-6d43a1c4-670c-4f7f-8926-aafe1d09c689.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0OTI2ODYsIm5iZiI6MTczOTQ5MjM4NiwicGF0aCI6Ii82NTk4ODI5LzQwNjA5ODczMy02ZDQzYTFjNC02NzBjLTRmN2YtODkyNi1hYWZlMWQwOWM2ODkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMDAxOTQ2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZmViOGExMTg0ZWYwNWViY2Y3ODc3NjViZDIzZjQ5YTMzMGFhZWNkNmZlMTc5YWY0MjhkZmZmNTFiZmY2YjA0MSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.YzIeeF7VcGh5LCRDDjmLaEeHJjt2yCUS2Vtt7fF6hwc)