containers/ws: Include cockpit-files #21558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings the ws container closer to the Client flatpak. In beiboot mode, Files works everywhere including RHEL 8 [1]. [1] cockpit-project/cockpit-files#917
martinpitt
added
no-test
|
FTR, we should clearly add podman and machines as well, I just thought I'd start small. |
jelly
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the ws container closer to the Client flatpak. In beiboot mode, Files works everywhere including RHEL 8 [1].
[1] cockpit-project/cockpit-files#917
Tested locally with
and then logging into
host.containers.internal(i.e. my laptop) on https://localhost:9999.cockpit/ws container: Include cockpit-files
The cockpit/ws container now includes cockpit-files. When you log into a remote machine that does not have any cockpit packages installed (package-less mode), the "Files" page is now available.