Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: Drop obsolete glib-networking dependency of bridge #21561

Merged
merged 1 commit into from
Jan 29, 2025
Merged

tools: Drop obsolete glib-networking dependency of bridge #21561

merged 1 commit into from
Jan 29, 2025

Conversation

martinpitt
Copy link
Member

This hasn't been necessary since the switch to the Python bridge.

@martinpitt
tools: Drop obsolete glib-networking dependency of bridge
1c77335 
This hasn't been necessary since the switch to the Python bridge.
@martinpitt martinpitt added the release-blocker Targetted for next release label Jan 28, 2025
@martinpitt martinpitt mentioned this pull request Jan 28, 2025
Merged
9 tasks
allisonkarlitskaya
allisonkarlitskaya approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@allisonkarlitskaya allisonkarlitskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Go to bed!

jelly
jelly requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@jelly jelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arch should also drop the dependency

tools/arch/PKGBUILD:makedepends=(krb5 accountsservice json-glib glib-networking glib2-devel
tools/arch/PKGBUILD: depends=(krb5 json-glib glib-networking python)

@martinpitt
Copy link
Member Author

@jelly I did consider it, but as cockpit-ws still uses needs it, I kept it. Note that both in rpm and deb cockpit-ws still has the dep, I only dropped it for bridge.

@martinpitt martinpitt requested a review from jelly January 28, 2025 20:57
martinpitt added a commit to martinpitt/bots that referenced this pull request Jan 29, 2025
@martinpitt
images: Add some Cockpit runtime and test deps to centos-9-bootc
7ec1697 
This will allow us to install cockpit-ws.rpm and run networking and
metrics tests.

Also toss in strace as the ultimate debugging tool, and rsync for
`build.js -r` and a more efficient bots API.

See cockpit-project/cockpit#21561
martinpitt added a commit to martinpitt/bots that referenced this pull request Jan 29, 2025
@martinpitt
images: Add some Cockpit runtime and test deps to centos-9-bootc
29d7495 
This will allow us to install cockpit-ws.rpm and run networking and
metrics tests.

Also toss in strace as the ultimate debugging tool, and rsync for
`build.js -r` and a more efficient bots API.

See cockpit-project/cockpit#21561
martinpitt added a commit to martinpitt/bots that referenced this pull request Jan 29, 2025
@martinpitt
images: Add some Cockpit runtime and test deps to centos-9-bootc
e928515 
This will allow us to install cockpit-ws.rpm and run networking and
metrics tests.

Also toss in strace as the ultimate debugging tool, and rsync for
`build.js -r` and a more efficient bots API.

See cockpit-project/cockpit#21561
@jelly
Copy link
Member

jelly commented Jan 29, 2025

@jelly I did consider it, but as cockpit-ws still uses needs it, I kept it. Note that both in rpm and deb cockpit-ws still has the dep, I only dropped it for bridge.

Ah, my late night review...

@martinpitt martinpitt merged commit 363a5c3 into cockpit-project:main Jan 29, 2025
87 checks passed
@martinpitt martinpitt deleted the glib-dep branch January 29, 2025 08:00
martinpitt added a commit to martinpitt/bots that referenced this pull request Jan 29, 2025
@martinpitt
images: Add some Cockpit runtime and test deps to centos-9-bootc
940f701 
This will allow us to install cockpit-ws.rpm and run networking and
metrics tests.

Also toss in strace as the ultimate debugging tool, and rsync for
`build.js -r` and a more efficient bots API.

See cockpit-project/cockpit#21561
martinpitt added a commit to martinpitt/bots that referenced this pull request Jan 30, 2025
@martinpitt
images: Add some Cockpit runtime and test deps to centos-9-bootc
1a3bf2e 
This will allow us to install cockpit-ws.rpm and run networking and
metrics tests.

Also toss in strace as the ultimate debugging tool, and rsync for
`build.js -r` and a more efficient bots API.

See cockpit-project/cockpit#21561
martinpitt added a commit to cockpit-project/bots that referenced this pull request Jan 30, 2025
@martinpitt
images: Add some Cockpit runtime and test deps to centos-9-bootc
08fea3f 
This will allow us to install cockpit-ws.rpm and run networking and
metrics tests.

Also toss in strace as the ultimate debugging tool, and rsync for
`build.js -r` and a more efficient bots API.

See cockpit-project/cockpit#21561
@martinpitt martinpitt mentioned this pull request Feb 4, 2025
Merged
1 task
martinpitt added a commit to cockpit-project/bots that referenced this pull request Feb 4, 2025
@martinpitt
images: Pre-install glib-networking on fedora-coreos
cfa2061 
cockpit-project/cockpit#21561 dropped
cockpit-bridge's glib-networking dependency. But two cockpit tests want
to install cockpit-ws, which still depends on glib-networking.
So put it back manually.

Drop the obsolete explicit python3 install, as cockpit-bridge has
depended on that for a long time.
jelly pushed a commit to cockpit-project/bots that referenced this pull request Feb 4, 2025
@martinpitt @jelly
images: Pre-install glib-networking on fedora-coreos
0bbb1c3 
cockpit-project/cockpit#21561 dropped
cockpit-bridge's glib-networking dependency. But two cockpit tests want
to install cockpit-ws, which still depends on glib-networking.
So put it back manually.

Drop the obsolete explicit python3 install, as cockpit-bridge has
depended on that for a long time.
jelly added a commit to cockpit-project/bots that referenced this pull request Feb 7, 2025
@jelly
images: Pre-install glib-networking on bootc
165be62 
cockpit-project/cockpit#21561 dropped
cockpit-bridge's glib-networking dependency. But two cockpit tests want
to install cockpit-ws, which still depends on glib-networking.
So put it back manually.
cockpituous pushed a commit to cockpit-project/bots that referenced this pull request Feb 7, 2025
@jelly
images: Pre-install glib-networking on bootc
542043b 
cockpit-project/cockpit#21561 dropped
cockpit-bridge's glib-networking dependency. But two cockpit tests want
to install cockpit-ws, which still depends on glib-networking.
So put it back manually.
martinpitt pushed a commit to cockpit-project/bots that referenced this pull request Feb 7, 2025
@jelly @martinpitt
images: Pre-install glib-networking on bootc
aba7f49 
cockpit-project/cockpit#21561 dropped
cockpit-bridge's glib-networking dependency. But two cockpit tests want
to install cockpit-ws, which still depends on glib-networking.
So put it back manually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelly jelly jelly approved these changes

@allisonkarlitskaya allisonkarlitskaya allisonkarlitskaya approved these changes

Assignees
No one assigned
Labels
release-blocker Targetted for next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinpitt @jelly @allisonkarlitskaya