test/common: don't reuse webdriver ids on exceptions #21608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use a `self.last_id` field to issue unique IDs for each async request we send to the browser, but only increment the ID after we get a successful reply. That breaks in situations where we get no reply, or an exception occurs. Sample the ID at the start and increment it immediately before `await`ing anything.
martinpitt
approved these changes
Feb 11, 2025
eh, I noticed it because it did happen... ...in response to a bug in Firefox, but still... |
|
Right, that's what I meant -- BiDi command not getting a response is the "should not happen" (but did anyway). Hence this is a nice robustification. Thanks for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a
self.last_idfield to issue unique IDs for each async request we send to the browser, but only increment the ID after we get a successful reply. That breaks in situations where we get no reply, or an exception occurs.Sample the ID at the start and increment it immediately before
awaiting anything.