test: Re-disable Firefox BiDi async events #21609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox 135 enabled async BiDi event dispatching [1]. This causes some regression where sometimes input events never get a response [2], which often breaks e.g. cockpit-podman's `testFailingPodmanService`. Re-disable async events for the time being to stabilize tests, until this gets debugged and fixed properly. Fixes cockpit-project/cockpit-podman#1999 [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1922077 [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1947402
martinpitt
added
the
no-test
|
Eh, where are my packit tests? But oh well, they wouldn't tell us much anyway, as cockpit is still using the old container with Firefox 134 (see #21600) |
allisonkarlitskaya
approved these changes
Feb 11, 2025
|
This fixes the issue in cockpit-project/cockpit-files#939, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox 135 enabled async BiDi event dispatching [1]. This causes some regression where sometimes input events never get a response [2], which often breaks e.g. cockpit-podman's
testFailingPodmanService.Re-disable async events for the time being to stabilize tests, until this gets debugged and fixed properly.
Fixes cockpit-project/cockpit-podman#1999
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1922077
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1947402
I ran the podman test umteen times in a loop (in the latest tasks container with Firefox 135), and it seems stable now.