tasks: Give S3 secrets to OpenShift tasks container #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit b742b2d was a thinko -- we *do* need S3 upload on our OpenShift tasks container: While we keep `test-results.db` in the local /cache/images/, we push `prometheus-stats` to S3.
allisonkarlitskaya
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit b742b2d was a thinko -- we do need S3 upload on our OpenShift tasks container: While we keep
test-results.dbin the local /cache/images/, we pushprometheus-statsto S3.I deployed this on OpenShift, and ran
in the terminal. This works now. I'm afraid it's too much manual effort to try and rescue the recently landed PRs, so we'll effectively rebuild the statistics from scratch now.