Skip to content

Comments

release-24.1: cli: harden debug sb recreate a bit#147810

Merged
yuzefovich merged 1 commit intocockroachdb:release-24.1from
yuzefovich:blathers/backport-release-24.1-147803
Jun 5, 2025
Merged

release-24.1: cli: harden debug sb recreate a bit#147810
yuzefovich merged 1 commit intocockroachdb:release-24.1from
yuzefovich:blathers/backport-release-24.1-147803

Conversation

@yuzefovich
Copy link
Member

@yuzefovich yuzefovich commented Jun 4, 2025

Backport 1/1 commits from #147803 on behalf of @yuzefovich.


This commit ensures that debug sb recreate command works on a statement bundle that has "default_transaction_use_follower_reads" session variable set (by resetting to the default). (A recent support bundle was failing recreation with a cryptic "resolved system to 1 but found no descriptor with id 1" error.)

Informs: https://github.com/cockroachlabs/support/issues/3317.
Epic: None
Release note: None


Release justification: debugging command improvement.

@yuzefovich yuzefovich force-pushed the blathers/backport-release-24.1-147803 branch from 3bc6527 to b6fef49 Compare June 4, 2025 23:50
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 4, 2025
@yuzefovich yuzefovich requested a review from a team as a code owner June 4, 2025 23:50
@yuzefovich yuzefovich added the blathers-backport This is a backport that Blathers created automatically. label Jun 4, 2025
@blathers-crl blathers-crl bot requested a review from DrewKimball June 4, 2025 23:50
@yuzefovich yuzefovich requested a review from a team as a code owner June 4, 2025 23:50
@yuzefovich yuzefovich requested review from angles-n-daemons and removed request for a team June 4, 2025 23:50
@blathers-crl
Copy link

blathers-crl bot commented Jun 4, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jun 4, 2025
@blathers-crl
Copy link

blathers-crl bot commented Jun 4, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich yuzefovich requested review from michae2 and removed request for a team and angles-n-daemons June 4, 2025 23:54
Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)

This commit ensures that `debug sb recreate` command works on
a statement bundle that has "default_transaction_use_follower_reads"
session variable set (by resetting to the default). (A recent support
bundle was failing recreation with a cryptic "resolved system to 1 but
found no descriptor with id 1" error.)

Release note: None
@yuzefovich yuzefovich force-pushed the blathers/backport-release-24.1-147803 branch from b6fef49 to 28baca7 Compare June 5, 2025 16:14
@yuzefovich yuzefovich merged commit 994832a into cockroachdb:release-24.1 Jun 5, 2025
15 checks passed
@yuzefovich yuzefovich deleted the blathers/backport-release-24.1-147803 branch June 5, 2025 16:52
@crl-codesys-jira crl-codesys-jira added the T-sql-queries SQL Queries Team label Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-sql-queries SQL Queries Team v24.1.20

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants