Skip to content

Conversation

@souravcrl
Copy link
Contributor

In compliance with CRDB-52600 and following #146290, will be moving forward to standarize the security metrics.

fixes: CRDB-52600

Release note (ops change): The following metrics will be marked as essential because they are needed for end user troubleshooting:

  • auth.jwt.conn.latency
  • auth.cert.conn.latency
  • auth.password.conn.latency
  • auth.ldap.conn.latency
  • auth.gss.conn.latency
  • auth.scram.conn.latency
  • auth.ldap.conn.latency.internal

@souravcrl souravcrl requested review from a team as code owners November 27, 2025 06:31
@blathers-crl
Copy link

blathers-crl bot commented Nov 27, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

In compliance with CRDB-52600 and following cockroachdb#146290, will be moving forward to
standarize the security metrics.

fixes: CRDB-52600

Release note (ops change): The following metrics will be marked as essential
because they are needed for end user troubleshooting:
- auth.jwt.conn.latency
- auth.cert.conn.latency
- auth.password.conn.latency
- auth.ldap.conn.latency
- auth.gss.conn.latency
- auth.scram.conn.latency
- auth.ldap.conn.latency.internal
@souravcrl souravcrl force-pushed the standardize-security-metrics branch from 44e578e to 56f1d91 Compare November 27, 2025 07:07
@souravcrl souravcrl requested a review from biplav-crl November 27, 2025 07:47
@blathers-crl
Copy link

blathers-crl bot commented Nov 27, 2025

Metrics change detected

This PR adds or updates one or more CRDB metrics. If you want these metrics to be exported by CRDB Cloud clusters to Internal CRL Datadog and/or included in the customer metric export integration (Essential metrics for standard deployment, and Essential metrics for advanced deployment), refer to this Installation and Usage guide of a CLI tool that syncs the metric mappings in managed-service. Run this CLI tool after your CRDB PR is merged.

  • The CLI opens a PR in managed-service with the required config changes.
  • Please track that PR and ensure it merges so your metrics become available to CRDB Cloud clusters.

Note: Your metric will appear in Internal CRL Datadog only after the managed-service PR merges and the new OTel configuration rolls out to at least one cluster running a CRDB build that includes this metric.

Docs: cockroach-metric-sync

Questions: reach out to @obs-india-prs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants