db: allow ingesting local SSTs with values in blob files #5620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary. After you review the findings, please tag the issue as follows:
|
Previously when ingesting local ssts we provided just the string paths as a slice. Now that we want to ingest tables with blob files, we introduce a new type that will track local sst paths and extra metadata like their blob file paths.
Allow ingesting local ssts and their associated blob files. Note that we do not validate blob value handles within a table. Each blob file is assumed to be valid for and fully referenced by the SST.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valsep: extract SSTBlobWriter test kv handling
db: add LocalSST struct containing metadata for local ingested files
Previously when ingesting local ssts we provided just the string paths as a
slice. Now that we want to ingest tables with blob files, we introduce a new
type that will track local sst paths and extra metadata like their blob file
paths.
db: allow ingesting local SSTs with values in blob files
Allow ingesting local ssts and their associated blob files. Note that we do not
validate blob value handles. Each blob file is assumed to be fully referenced by
the SST.