fix: Update license scanning support #2360
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that for all supported languages (except PHP/Composer), Trivy can't provide license information unless the dependencies have been dowloaded locally.
This does not necessarily mean we have to build the client's code, as many languages/package managers provide a way to just download the dependencies, but since tools don't have internet access we can't provide license information when we run Trivy like we thought.
Again, except for PHP/Composer, license information will not be provided by running Trivy.