Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update license scanning support #2360

Merged
merged 1 commit into from
Mar 7, 2025
Merged

fix: Update license scanning support #2360

merged 1 commit into from
Mar 7, 2025

Conversation

afsmeira
Copy link
Contributor

@afsmeira afsmeira commented Mar 7, 2025

It turns out that for all supported languages (except PHP/Composer), Trivy can't provide license information unless the dependencies have been dowloaded locally.

This does not necessarily mean we have to build the client's code, as many languages/package managers provide a way to just download the dependencies, but since tools don't have internet access we can't provide license information when we run Trivy like we thought.

Again, except for PHP/Composer, license information will not be provided by running Trivy.

@afsmeira afsmeira requested a review from a team March 7, 2025 16:51
@afsmeira afsmeira requested a review from a team as a code owner March 7, 2025 16:51
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Overall readability score: 53.24 (🟢 +0)

File Readability
supported-languages-and-tools.md 47.6 (🟢 +0)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
supported-languages-and-tools.md 47.6 31.17 10.59 13.8 15.07 7.71
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0

Averages:

  Readability FRE GF ARI CLI DCRS
Average 53.24 42.72 10.89 12.64 12.69 7.96
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

@afsmeira afsmeira merged commit 9ddc958 into master Mar 7, 2025
6 checks passed
@afsmeira afsmeira deleted the fix/licenses branch March 7, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants