45 timezone #47
Merged
45 timezone #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#45
Timezone bugfix
IssueListOption and IssueListOption4Repository class have q method.
This method serialize datetime with TimeZone. (e.g. 2015-05-25T10:00:00+0900)
But maybe GitHub service doesn't recognize TimeZone.
So, we have to serialize datetime always as UTC.
Rewrite Option#get
Option#get is not recommended in production code.
Though I usually use Option#get in test code, I never use this method in production code.
It is better to use getOrElse or pattern match.
@fanwashere review me