Fix 12 search api #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ashawley
force-pushed
the
fix-12-SearchApi
branch
from
67a7316 to
0ec6175
Compare
ashawley
force-pushed
the
fix-12-SearchApi
branch
from
0ec6175 to
1cd570e
Compare
ashawley
commented
Feb 21, 2017
|
|
||
| def description = opt("description") | ||
| def open_issues_count = get("open_issues_count").toInt | ||
| def open_issues_count = get("open_issues_count").toLong |
There was a problem hiding this comment.
This was the only compatibility change in this pull request.
There was no test case to catch it. The RepositoryCommand uses it, but the generic PrintList.build function doesn't care about the type.
|
Currently I don't use this API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've finished the work @sukeshni started on the search API in #36.
I resolved all the comments and suggestions that @shunjikonishi and @fanwashere raised about code search results. I also improved the unit tests.