Skip to content

Feat:FixJSON/file-ProviderFileForNile #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

nilejack
Copy link
Contributor

  • feat:adds lesson_07/conditionals-nilejackson
  • feat: completedLesson09/HW
  • feat: adds/NileJack/Lesson_09HW
  • "feat:adds/JSON.file"
  • Delete lesson_07/conditionals/src/lesson7.ts
  • Revert "feat:adds lesson_07/conditionals-nilejackson"

@nilejack
Copy link
Contributor Author

Build for lesson09 worked, but I was unable to get rid of this lesson_07.ts file after running the commands in Chelsea's comments.

@anthonydmays
Copy link
Contributor

Build for lesson09 worked, but I was unable to get rid of this lesson_07.ts file after running the commands in Chelsea's comments.

git checkout 70dccf221599fa5e10a335f17faa3a77abfa3950 -- lesson_07/conditionals/src/lesson7.ts
git commit -am "chore: removes changes to lesson7"

Copy link
Contributor

@anthonydmays anthonydmays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't submit with the lesson7.ts file change. Get that resolved and then I can get this in for you.

return "nilejack";
}

@SuppressWarnings("rawtypes")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this, please remove.

@anthonydmays
Copy link
Contributor

Also, keep working on providing better names for your pull requests. Take a look at the conventional commits article again and note other pull requests so that you are following the established standard.

https://www.conventionalcommits.org/en/v1.0.0/

@nilejack nilejack closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants