feat: implement bank account system with audit logging and support fo… #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r multiple account types
anthonydmays
requested changes
Apr 14, 2025
|
|
||
| // Method to add a value to an existing ArrayList or create a new one if accountNumber doesn't | ||
| // exist | ||
| public void addToMap( |
There was a problem hiding this comment.
This is weird. Maybe do some research on how to build a logger object. No too difficult to make a simple one.
| import java.util.HashSet; | ||
| import java.util.Set; | ||
|
|
||
| public abstract class BankAccount { |
There was a problem hiding this comment.
Instead of building your own BankAccount class from scratch, you could take the logic from CheckingAccount.
| @@ -128,4 +132,19 @@ public String toString() { | |||
| + isActive | |||
| + '}'; | |||
| } | |||
| @Override | |||
| public void withdraw(double amount) throws InsufficientFundsException { | |||
There was a problem hiding this comment.
This should all be in the superclass since these are good checks for all accounts, no matter the type.
| this.isBusiness = isBusiness; | ||
| } | ||
|
|
||
| public boolean isBusiness() { |
…CheckingAccount classes
…sts; enhance Check and BankAccount classes
…ed account instance
|
I tried... Ant don't cook me... Remember you said "perfect is the enemy of good." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not finished still working on it.... can I get my extension please?