Skip to content

feat: implements bank account system with checking and savings account. #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
package com.codedifferently.lesson17.bank;

import com.codedifferently.lesson17.bank.exceptions.InsufficientFundsException;
import java.util.Set;

/**
* Checks if the account is closed
*
* @returns true if the account is closed, otherwise false
*/
public abstract class BankAccount {
private String accountNumber;
protected double balance;
private Set<Customer> owners;
private boolean isClosed;

public BankAccount(String accountNumber, Set<Customer> owners, double initialBalance) {
this.accountNumber = accountNumber;
this.owners = owners;
this.balance = initialBalance;
}

public boolean isActive() {
return isClosed;
}

/**
* Gets the owners of the account.
*
* @return The owners of the account.
*/
public Set<Customer> getOwners() {
return owners;
}

/**
* Gets the account number.
*
* @return The account number.
*/
public String getAccountNumber() {
return accountNumber;
}

/**
* Withdraws funds from the account.
*
* @param amount
* @throws InsufficientFundsException
*/
public void withdraw(double amount) throws InsufficientFundsException {
if (amount <= 0) {
throw new IllegalStateException("Withdrawal amount must be positive");
}
if (balance < amount) {
throw new InsufficientFundsException("Account does not have enough funds for withdrawal");
}
balance -= amount;
}

/**
* Deposits funds into the account.
*
* @param amount The amount to deposit.
*/
public void deposit(double amount) throws IllegalStateException {

if (amount <= 0) {
throw new IllegalArgumentException("Deposit amount must be positive");
}
balance += amount;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ public class BankAtm {

private final Map<UUID, Customer> customerById = new HashMap<>();
private final Map<String, CheckingAccount> accountByNumber = new HashMap<>();
private final Map<String, SavingsAccount> savingsAccountByNumber = new HashMap<>();

/**
* Adds a checking account to the bank.
Expand All @@ -27,13 +28,28 @@ public void addAccount(CheckingAccount account) {
});
}

/**
* Adds a savings account to the bank.
*
* @param account The account to add.
*/
public void addAccount(SavingsAccount account) {
savingsAccountByNumber.put(account.getAccountNumber(), account);
account
.getOwners()
.forEach(
owner -> {
customerById.put(owner.getId(), owner);
});
}

/**
* Finds all accounts owned by a customer.
*
* @param customerId The ID of the customer.
* @return The unique set of accounts owned by the customer.
*/
public Set<CheckingAccount> findAccountsByCustomerId(UUID customerId) {
public Set<BankAccount> findAccountsByCustomerId(UUID customerId) {
return customerById.containsKey(customerId)
? customerById.get(customerId).getAccounts()
: Set.of();
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package com.codedifferently.lesson17.bank;

import java.util.Set;

/** Represents a business checking account. */
public class BusinessCheckingAccount extends BankAccount {

/**
* Creates a new business checking account.
*
* @param accountNumber The account number.
* @param owners The owners of the account.
* @param initialBalance The initial balance of the account.
*/
public BusinessCheckingAccount(
String accountNumber, Set<Customer> owners, double initialBalance) {
super(accountNumber, owners, initialBalance);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -79,4 +79,8 @@ public String toString() {
+ account.getAccountNumber()
+ '}';
}

public Object getAmount() {
throw new UnsupportedOperationException("Unimplemented method 'getAmount'");
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@
import java.util.Set;

/** Represents a checking account. */
public class CheckingAccount {
public class CheckingAccount extends BankAccount {

private final Set<Customer> owners;
private final String accountNumber;
private double balance;
private boolean isActive;
Expand All @@ -19,62 +18,10 @@ public class CheckingAccount {
* @param initialBalance The initial balance of the account.
*/
public CheckingAccount(String accountNumber, Set<Customer> owners, double initialBalance) {
super(accountNumber, owners, initialBalance);
this.accountNumber = accountNumber;
this.owners = owners;
this.balance = initialBalance;
isActive = true;
}

/**
* Gets the account number.
*
* @return The account number.
*/
public String getAccountNumber() {
return accountNumber;
}

/**
* Gets the owners of the account.
*
* @return The owners of the account.
*/
public Set<Customer> getOwners() {
return owners;
}

/**
* Deposits funds into the account.
*
* @param amount The amount to deposit.
*/
public void deposit(double amount) throws IllegalStateException {
if (isClosed()) {
throw new IllegalStateException("Cannot deposit to a closed account");
}
if (amount <= 0) {
throw new IllegalArgumentException("Deposit amount must be positive");
}
balance += amount;
}

/**
* Withdraws funds from the account.
*
* @param amount
* @throws InsufficientFundsException
*/
public void withdraw(double amount) throws InsufficientFundsException {
if (isClosed()) {
throw new IllegalStateException("Cannot withdraw from a closed account");
}
if (amount <= 0) {
throw new IllegalStateException("Withdrawal amount must be positive");
}
if (balance < amount) {
throw new InsufficientFundsException("Account does not have enough funds for withdrawal");
}
balance -= amount;
this.isActive = true;
}

/**
Expand Down Expand Up @@ -103,6 +50,18 @@ public boolean isClosed() {
return !isActive;
}

@Override
public void withdraw(double amount) throws InsufficientFundsException {
super.withdraw(amount);
balance -= amount;
}

@Override
public void deposit(double amount) {
super.deposit(amount);
balance += amount;
}

@Override
public int hashCode() {
return accountNumber.hashCode();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ public class Customer {

private final UUID id;
private final String name;
private final Set<CheckingAccount> accounts = new HashSet<>();
private final Set<BankAccount> accounts = new HashSet<>();

/**
* Creates a new customer.
Expand Down Expand Up @@ -43,19 +43,24 @@ public String getName() {
/**
* Adds a checking account to the customer.
*
* @param account The account to add.
* @param account3 The account to add.
*/
public void addAccount(CheckingAccount account) {
accounts.add(account);
public void addAccount(CheckingAccount account3) {
accounts.add(account3);
}

/**
* Gets the accounts owned by the customer.
*
* @return The unique set of accounts owned by the customer.
*/
public Set<CheckingAccount> getAccounts() {
return accounts;
public Set<BankAccount> getAccounts() {
return new HashSet<>(accounts);
}

/** check if is business account */
public boolean isBusinessAccount() {
return accounts.stream().anyMatch(BusinessCheckingAccount.class::isInstance);
}

@Override
Expand All @@ -65,10 +70,14 @@ public int hashCode() {

@Override
public boolean equals(Object obj) {
if (obj instanceof Customer other) {
return id.equals(other.id);
if (this == obj) {
return true;
}
if (obj == null || getClass() != obj.getClass()) {
return false;
}
return false;
Customer other = (Customer) obj;
return id.equals(other.id) && name.equals(other.name);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
package com.codedifferently.lesson17.bank;

import java.util.Set;

/** Represents a savings account that doesn't allow checks. */
public class SavingsAccount extends BankAccount {
private boolean isActive = true;

public SavingsAccount(String accountNumber, Set<Customer> owners, double initialBalance) {
super(accountNumber, owners, initialBalance);
}

protected boolean isClosed() {
throw new IllegalStateException("Cannot check if account is closed");
}

@Override
public boolean isActive() {
return true;
}

public void closeAccount() {
throw new IllegalStateException("Cannot close account with a positive balance");
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
package com.codedifferently.lesson17.bank;

import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertEquals;

import java.util.HashSet;
import java.util.Set;
import java.util.UUID;
import org.junit.jupiter.api.Test;

public class BankAccountTest {
@Test
void testIsActive() {
// Arrange
Set<Customer> owners = new HashSet<>();
owners.add(new Customer(UUID.randomUUID(), "John Doe"));
BankAccount account = new CheckingAccount("123456789", owners, 100.0);
// Act
boolean isActive = account.isActive();
// Assert
assertThat(!isActive).isTrue();
}

@Test
void testGetOwners() {
// Act
Set<Customer> owners = new HashSet<>();
owners.add(new Customer(UUID.randomUUID(), "John Doe"));
BankAccount account = new CheckingAccount("123456789", owners, 100.0);
// Assert
assertEquals(owners, account.getOwners());
}

@Test
void testWithdrawFunds() {
// Arrange
double initialBalance = 100.0;
double withdrawAmount = 50.0;
double expectedBalance = initialBalance - withdrawAmount;

// Act
BankAccount account = new CheckingAccount("123456789", null, initialBalance);
account.withdraw(withdrawAmount);

// Assert
assertThat(account.balance).isEqualTo(expectedBalance);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,14 @@ void testAddAccount() {
classUnderTest.addAccount(account3);

// Assert
Set<CheckingAccount> accounts = classUnderTest.findAccountsByCustomerId(customer3.getId());
Set<BankAccount> accounts = classUnderTest.findAccountsByCustomerId(customer3.getId());
assertThat(accounts).containsOnly(account3);
}

@Test
void testFindAccountsByCustomerId() {
// Act
Set<CheckingAccount> accounts = classUnderTest.findAccountsByCustomerId(customer1.getId());
Set<BankAccount> accounts = classUnderTest.findAccountsByCustomerId(customer1.getId());

// Assert
assertThat(accounts).containsOnly(account1, account2);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
package com.codedifferently.lesson17.bank;

public class BusinessCheckingAccountTest {}
Loading