Feat: adds audit logging and multi-currency support to BankAtm #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osits - Modified BankAtm, AuditLog, and CurrencyConverter to support new features - Added MoneyOrder class for handling money order transactions - Implemented SimpleCurrencyConverter for basic currency conversion logic - Introduced CurrencyConverterException to handle conversion errors - Updated BankAtmTest with new test cases for added functionality
anthonydmays
requested changes
Apr 23, 2025
Contributor
anthonydmays
left a comment
anthonydmays
left a comment
There was a problem hiding this comment.
Formatting needs to be fixed.
| private final Map<String, CheckingAccount> accountByNumber = new HashMap<>(); | ||
| private final AuditLog auditLog; | ||
|
|
||
| public BankAtm(AuditLog auditLog) { |
Contributor
There was a problem hiding this comment.
A constructor doesn't exist without a class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still working on this! It's super red!!