Skip to content

Update CODEOWNERS for component library packages #65296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025

Conversation

bethanyaconnor
Copy link
Contributor

@bethanyaconnor bethanyaconnor commented Apr 16, 2025

Automatically tags the engineers who review component library changes.

Warning!!

The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2025. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Contributor

@kelbyhawn kelbyhawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add similar rules for anything in the frontend/apps directory too? cc @levadadenys

@bethanyaconnor bethanyaconnor marked this pull request as ready for review April 17, 2025 12:11
@bethanyaconnor bethanyaconnor requested a review from a team as a code owner April 17, 2025 12:11
@bethanyaconnor bethanyaconnor requested a review from a team April 17, 2025 12:11
Copy link
Contributor

@levadadenys levadadenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 Thank you!

@bethanyaconnor bethanyaconnor merged commit 3d0ccb8 into staging Apr 22, 2025
6 checks passed
@bethanyaconnor bethanyaconnor deleted the bethany/component-library-code-owners branch April 22, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants