Added multimodal logic to aichat_request_chat_completion_job #65328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sted expected length test
… detection to job start
sanchitmalhotra126
approved these changes
Apr 21, 2025
Comment on lines
+55
to
+58
| messages_with_assets_count = messages.count do |message| | ||
| message['assets']&.any? | ||
| end | ||
| return messages_with_assets_count>0 |
There was a problem hiding this comment.
nit: you can simplify the return value to just
messages.count do |message|
message['assets']&.any?
end
rather than storing a message_with_assets_count local variable
| @@ -50,6 +50,14 @@ def perform(request:, locale:) | |||
| request.update!(response: response, execution_status: status) | |||
| end | |||
|
|
|||
| private def multimodal?(request) | |||
There was a problem hiding this comment.
Minor: can we move this below around line 110 so it's grouped with the other similar get_model_id helper?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
New Metrics Payload in Cloudwatch