New teacher homepage eyes test #65375
Open
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dot-org/code-dot-org into new-teacher-homepage-eyes-test
Nokondi
commented
Apr 18, 2025
| @@ -4,6 +4,7 @@ import PropTypes from 'prop-types'; | |||
| import React from 'react'; | |||
|
|
|||
| import {queryParams} from '@cdo/apps/code-studio/utils'; | |||
| import DCDO from '@cdo/apps/dcdo'; | |||
There was a problem hiding this comment.
FYI, the DCDO stuff is part of this PR which hasn't merged yet. Will rebase and merge once that one is approved and merged.
…ew-teacher-homepage-eyes-test
lfryemason
reviewed
Apr 21, 2025
| Scenario: Teacher can view sections on new teacher homepage | ||
| When I open my eyes to test "teacher homepage" | ||
| Given I am a teacher | ||
| Then I use a cookie to mock the DCDO key "teacher-homepage-v2" as "true" |
There was a problem hiding this comment.
I think we should create at least one section with student and curriculum assigned so that we are testing the section cards as well. What do you think?
…ew-teacher-homepage-eyes-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds a simple eyes test for the new teacher homepage. Additional UI and eyes tests will be added in a future update.
Warning!!
The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2025. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: