switch contact action to text #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tsml-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
gkovats
reviewed
Oct 1, 2024
| @@ -189,8 +189,8 @@ export default function Meeting({ | |||
| if (meeting[`contact_${i}_phone` as keyof typeof Meeting]) | |||
There was a problem hiding this comment.
Not sure how often folks enter a phone without a name (contact_1_name doesn't exist but contact_1_phone does), could the group name default in the button label?
There was a problem hiding this comment.
thanks - i set it up this way to encourage admins to enter a name, since the intent of this field is to list individuals (there's a separate field in the plugin for group / meeting phone) but happy to discuss it
i'll move forward with this change since it's not altering the behavior
gkovats
approved these changes
Oct 1, 2024
joshreisner
deleted the
396-change-group-contact_x_phone-action-to-text-instead-of-call
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #396