change the button href for "text" contact buttons #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tsml-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joshreisner
changed the title
…ext-instead-of-call-2
|
on ios i can confirm this hands off properly to the messages app - i'll test on android as well tonight |
|
going to ship this since it's confirmed working on ios and android |
joshreisner
deleted the
396-change-group-contact_x_phone-action-to-text-instead-of-call-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
welp i changed the appearance of the button but did not actually change the href of the button as was the original request in #396 🤦
this pr changes the button from a
tel:link to asms:linkcurious what the behavior is on desktop since my laptop has the Messages app blocked 😢
example with the "text" button enabled: https://deploy-preview-420--tsml-ui.netlify.app/tests/times.html?meeting=monday-7pm