Skip to content

Saso/metrics patch 1 #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Saso/metrics patch 1 #470

wants to merge 4 commits into from

Conversation

iamsaso
Copy link
Contributor

@iamsaso iamsaso commented May 3, 2019 •
edited by aballman
Loading

  • Use environment.Key instead of Name
  • If environment is NotFound set it to -1

@codecov
Copy link

codecov bot commented May 3, 2019 •
edited
Loading

Codecov Report

Merging #470 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
- Coverage   50.32%   50.27%   -0.05%     
==========================================
  Files          74       74              
  Lines        8384     8384              
==========================================
- Hits         4219     4215       -4     
- Misses       3658     3662       +4     
  Partials      507      507

@aballman
Copy link
Contributor

aballman commented May 3, 2019

What was wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aballman aballman aballman approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamsaso @aballman @drshrey