Replace Mailchimp with a Flodesk integration #2162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnclmorais
force-pushed
the
me-from-mailchimp-to-flowdesk
branch
from
a490c5b to
fc6ba1b
Compare
gnclmorais
commented
Jan 25, 2025
gnclmorais
commented
Jan 25, 2025
gnclmorais
force-pushed
the
me-from-mailchimp-to-flowdesk
branch
3 times, most recently
from
10c5afc to
5795169
Compare
|
@gnclmorais I think we are OK to ignore those codeclimate issues for now, they do seem to be a bit strict. UPDATE: I have marked them as won't fix for now so all checks pass. |
matyikriszta
approved these changes
Feb 4, 2025
gnclmorais
force-pushed
the
me-from-mailchimp-to-flowdesk
branch
5 times, most recently
from
003c7a7 to
0cd5f2d
Compare
spec/lib/services/flodesk_spec.rb
Outdated
| stub.verify_stubbed_calls | ||
| end | ||
|
|
||
| it 'confirms that a user is active but not not subscribed to a segment' do |
There was a problem hiding this comment.
Suggested change
| it 'confirms that a user is active but not not subscribed to a segment' do | |
| it 'confirms that a user is active but not subscribed to a segment' do |
matyikriszta
approved these changes
Feb 25, 2025
gnclmorais
force-pushed
the
me-from-mailchimp-to-flowdesk
branch
from
0cd5f2d to
4631b22
Compare
This will allow us to reduce emailing costs by a factor of 10.
gnclmorais
force-pushed
the
me-from-mailchimp-to-flowdesk
branch
from
4631b22 to
720a7e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does what it says in the tin. When complete, this will close #2139. These changes will be tested locally with a real API key when we are sure this is in a good state (as far as we can see) to merge.
The only noticeable change for users is the styling of the newsletter call to action section that can be found on the homepage, for example:
@matyikriszta, let me know what you think about the CodeClimate warnings, but I think they are a bit too zealous.