-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Added identifierType=alias to the OpsGenie close URL #4557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Added identifierType=alias to the OpsGenie close URL #4557
Conversation
… OpsGenieNotifier.buildUrl. This identifierType is required to successfully close an open alert when using an alias as the identifier.
Here is a link to the issue where I reported this bug: #4551 I accidentally closed the ticket when leaving a comment. Hopefully someone with permission can reopen it for me. |
Not sure, why this pull request is stuck. Will try to close and then reopen it. |
… OpsGenieNotifier.buildUrl. This identifierType is required to successfully close an open alert when using an alias as the identifier.
3d2af45
to
c750248
Compare
@AE-RobertMcDonnell Thank you for your contribution! There are test failures, could you please have a look? |
…Notifier.buildUrl() method, this time with updates to the unit test.
Head branch was pushed to by a user without write access
…er-buildurl' into bugfix/add-identifiertype-to-opsgenienotifier-buildurl
I pushed commits that update the unit test. I see that Yash's push was rejected. The updated branch should pass tests now. |
…er-buildurl' into bugfix/add-identifiertype-to-opsgenienotifier-buildurl
…genienotifier-buildurl' into bugfix/add-identifiertype-to-opsgenienotifier-buildurl
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4557 +/- ##
============================================
- Coverage 83.64% 82.37% -1.28%
+ Complexity 1247 1220 -27
============================================
Files 156 164 +8
Lines 3644 4113 +469
Branches 258 257 -1
============================================
+ Hits 3048 3388 +340
- Misses 464 603 +139
+ Partials 132 122 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… OpsGenieNotifier.buildUrl. This identifierType is required to successfully close an open alert when using an alias as the identifier.