Skip to content

Added identifierType=alias to the OpsGenie close URL #4557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

AE-RobertMcDonnell
Copy link

… OpsGenieNotifier.buildUrl. This identifierType is required to successfully close an open alert when using an alias as the identifier.

… OpsGenieNotifier.buildUrl. This identifierType is required to successfully close an open alert when using an alias as the identifier.
@AE-RobertMcDonnell
Copy link
Author

Here is a link to the issue where I reported this bug: #4551

I accidentally closed the ticket when leaving a comment. Hopefully someone with permission can reopen it for me.

@hzpz
Copy link
Contributor

hzpz commented Aug 10, 2025

Not sure, why this pull request is stuck. Will try to close and then reopen it.

… OpsGenieNotifier.buildUrl. This identifierType is required to successfully close an open alert when using an alias as the identifier.
@SteKoe SteKoe force-pushed the bugfix/add-identifiertype-to-opsgenienotifier-buildurl branch from 3d2af45 to c750248 Compare August 11, 2025 07:39
@hzpz hzpz enabled auto-merge (squash) August 11, 2025 07:42
@hzpz
Copy link
Contributor

hzpz commented Aug 11, 2025

@AE-RobertMcDonnell Thank you for your contribution! There are test failures, could you please have a look?

…Notifier.buildUrl() method, this time with updates to the unit test.
auto-merge was automatically disabled August 11, 2025 16:21

Head branch was pushed to by a user without write access

…er-buildurl' into bugfix/add-identifiertype-to-opsgenienotifier-buildurl
@AE-RobertMcDonnell
Copy link
Author

I pushed commits that update the unit test. I see that Yash's push was rejected. The updated branch should pass tests now.

AE-RobertMcDonnell and others added 3 commits August 11, 2025 10:46
…er-buildurl' into bugfix/add-identifiertype-to-opsgenienotifier-buildurl
…genienotifier-buildurl' into bugfix/add-identifiertype-to-opsgenienotifier-buildurl
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.37%. Comparing base (4f9d0ae) to head (45e7c4c).
⚠️ Report is 2459 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4557      +/-   ##
============================================
- Coverage     83.64%   82.37%   -1.28%     
+ Complexity     1247     1220      -27     
============================================
  Files           156      164       +8     
  Lines          3644     4113     +469     
  Branches        258      257       -1     
============================================
+ Hits           3048     3388     +340     
- Misses          464      603     +139     
+ Partials        132      122      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants