New option compareWithImage to compare a screenshot with a custom file
#90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Code ignored the flag `config.prepareBaseImage` 2. There was a typo in the function name `_getBaseImageName()`
stracker-phil
commented
Aug 9, 2021
| } | ||
| if (options.prepareBaseImage !== undefined && options.prepareBaseImage) { | ||
|
|
||
| if (this._getPrepareBaseImage(options)) { |
There was a problem hiding this comment.
This change also addresses the following bug report:
|
thanks a lot for the PR, I am going to test the changes also requested @fsblemos to also verify the PR, will prepare a new release post that with your improvement and fixes |
fsblemos
approved these changes
Aug 10, 2021
puneet0191
added a commit
that referenced
this pull request
Aug 10, 2021
…ile (#90) (#91) * Add option `compareWithImage` * Cleanup changes from previous commit * Document changes for `compareWithImage` option * Improve `compareWithImage` documentation * Fix issues from previous commit 1. Code ignored the flag `config.prepareBaseImage` 2. There was a typo in the function name `_getBaseImageName()` Co-authored-by: Philipp Stracker <[email protected]>
puneet0191
added a commit
that referenced
this pull request
Aug 10, 2021
* New option `compareWithImage` to compare a screenshot with a custom file (#90) (#91) * Add option `compareWithImage` * Cleanup changes from previous commit * Document changes for `compareWithImage` option * Improve `compareWithImage` documentation * Fix issues from previous commit 1. Code ignored the flag `config.prepareBaseImage` 2. There was a typo in the function name `_getBaseImageName()` Co-authored-by: Philipp Stracker <[email protected]> * Update Version Co-authored-by: Philipp Stracker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new and optional option value that allows to compare a screenshot to a base-image with a different file name.
Reasons for this: