update phpunit #127
update phpunit #127
Conversation
|
Apologies for the delay in reviewing this. Will you summarize what is the value in updating this? It doesn't seem like we're taking advantage of any new functionality or bug fixes. |
|
PHPUnit 4.8 had hit its end of support in the year 2015 (as I remember). It should be possible to use newer versions of PHPUnit on newer versions of PHP. |
|
Thanks for explaining. Just to be clear, though, does this change affect users of the php test reporter? |
phpunit.xml.dist
Outdated
| @@ -2,15 +2,19 @@ | |||
|
|
|||
| <phpunit | |||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/4.8/phpunit.xsd" | |||
| xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/5.7/phpunit.xsd" | |||
There was a problem hiding this comment.
How about referencing the schema by a relative URL?
-xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/5.7/phpunit.xsd"
+xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"This way it will always be accurate, regardless of which version of phpunit/phpunit is installed.
There was a problem hiding this comment.
I didn't know this is possible.
| @@ -4,7 +4,7 @@ | |||
| use CodeClimate\PhpTestReporter\Application; | |||
| use Symfony\Component\Console\Tester\ApplicationTester; | |||
|
|
|||
| class ApplicationTest extends \PHPUnit_Framework_TestCase | |||
| class ApplicationTest extends \PHPUnit\Framework\TestCase | |||
There was a problem hiding this comment.
Ha, nice, wasn't aware it's been backported to 4.8, see https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-4.8.md#4835---2017-02-06!
|
No, this only affects contributors, not users! |
composer.json
Outdated
| @@ -28,7 +28,7 @@ | |||
| }, | |||
| "require-dev": { | |||
| "friendsofphp/php-cs-fixer": "^2.0.0", | |||
| "phpunit/phpunit": "^4.8.31" | |||
| "phpunit/phpunit": "^4.8.35 || ^5.7 || ^6.0" | |||
There was a problem hiding this comment.
One more thing, how about making it more obvious which minor versions we are fine with?
-"phpunit/phpunit": "^4.8.35 || ^5.7 || ^6.0"
+"phpunit/phpunit": "^4.8.35 || ^5.7.0 || ^6.0.0"This way it is very accurately documented.
|
👍 feel free to squash and merge @localheinz |
|
Thank you, @mimmi20! |
This PR tries to allow newer versions of PHPunit and changes to the namespaced version of the base test class.
This PR is a part of previous PR #124.