Parallel workers and look up data url #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes it's relevant to that, but I've been looking at it as part of #21, as that will increase the amount of work further. This is functionality the stats runner has to split the loop step by file, and distribute the work between multiple processes: https://github.com/codeforIATI/IATI-Stats/blob/main/statsrunner/loop.py#L167-L172. I've set this to 2, as GitHub actions gets access to 2 cores. |
|
Okay nice, sounds good. Ahhh – I see you’ve tried it on dev, and it looks like it makes a big improvement to the workflow run time! That’s fab, let’s definitely get this merged |
andylolz
approved these changes
Sep 26, 2022
|
(Thanks also for explaining this Ben!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.