[CCAP-651] - applications should only route to active SDAs #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analoo
changed the title
analoo
commented
Feb 24, 2025
| @@ -47,11 +44,12 @@ public void run(Submission submission) { | |||
|
|
|||
| if (!experiencingHomelessness && hasValidValue(inputData, UNVALIDATED_ZIPCODE_INPUT_NAME)) { | |||
| final String unvalidatedZip = (String) submission.getInputData().get(UNVALIDATED_ZIPCODE_INPUT_NAME); | |||
| saveCountyFromZip(submission, unvalidatedZip); | |||
There was a problem hiding this comment.
only saves county from home zip code address
analoo
commented
Feb 24, 2025
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| @Service | |||
| public class ApplicationRoutingServiceImpl implements ApplicationRouterService{ | |||
|
|
|||
| private final List<String> activeCaseLoadCodes = List.of("BB", "QQ"); | |||
There was a problem hiding this comment.
Limits resources orgs to those that are included in this list.
analoo
commented
Feb 24, 2025
| @@ -106,28 +107,6 @@ void fullGccFlow() throws IOException { | |||
| // parent-info-disability | |||
| assertThat(testPage.getTitle()).isEqualTo(getEnMessage("parent-info-disability.title")); | |||
| testPage.clickYes(); | |||
| // parent-home-address | |||
There was a problem hiding this comment.
had to change order because otherwise we submit an unhoused application which means we cannot test county
analoo
commented
Feb 24, 2025
| // Click it twice so it populates the mailing address fields | ||
| testPage.clickElementById("parentMailingAddressSameAsHomeAddress-yes"); | ||
| // Check that JS is correct populating fields when selecting same as home address | ||
| assertThat(testPage.getInputValue("parentMailingStreetAddress1")).isEqualTo("123 Main St"); |
There was a problem hiding this comment.
changes to an Illinois sounding address for testing
analoo
force-pushed
the
CCAP-651-applications-routing-sda6-bug
branch
from
992f75f to
e418a41
Compare
analoo
changed the title
cram-cfa
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Jira ticket
CCAP-651
✍️ Description
applicantAddressCountybased on the parent home address, regardless of what SDA is in scope📷 Design reference
Steps to reproduce the bug
Expected behavior
Until we launch in SDA 6, no applications should be routed there. Applications with an SDA 6 home address for the applicant should fall back to routing by the County or zip selected in onboarding in the same way that out of state zip codes do.
✅ Completion tasks