-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating FFL fragments #72
Conversation
<div class="form-card__content"> | ||
<th:block th:replace="~{'fragments/inputs/checkboxFieldset' :: | ||
<th:block th:replace="~{fragments/inputs/checkboxFieldset :: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sree-cfa, how many options can the user check on this screen? If only one is possible, it should be Radio.
@@ -59,22 +54,10 @@ | |||
</th:block> | |||
</th:block> | |||
|
|||
<th:block th:replace="~{'fragments/inputs/checkboxFieldset' :: | |||
<th:block th:replace="~{fragments/inputs/checkboxFieldset :: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gender and race should be checked as only one option, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question - I'll double check with Carlie. The design shows checkboxes implying it can have multiple answers so I'll leave it like that for now
✍️ Description
Updated the checkbox and radio fieldset fragments to be able to take a collection of options.
The
options
param are values from classes that implementInputOption
. They must have a value and label/helpText are optional. This is to simplify rendering for static checkboxes and have a more centralized way of referencing these values in html rendering and PDF generation.*Backwards compatible.