Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding axe tests #76

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Adding axe tests #76

merged 6 commits into from
Mar 5, 2024

Conversation

sree-cfa
Copy link
Contributor

🔗 Pivotal Tracker ticket

PT#186712950

✍️ Description

Adding axe devtools unit tests to catch some accessibility violations

@sree-cfa sree-cfa marked this pull request as ready for review February 27, 2024 00:26
@cy-by cy-by self-requested a review March 1, 2024 17:06
cy-by
cy-by approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@cy-by cy-by left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, was able to run a11y tests locally.

@sree-cfa
Copy link
Contributor Author

sree-cfa commented Mar 4, 2024

approved, was able to run a11y tests locally.

Thanks! I overrode the "inputError" fragment with the title change - I'll just keep a tab on that for how we decide to address that in the FFL itself

@sree-cfa sree-cfa temporarily deployed to test-il-gcc-pr-76 March 5, 2024 01:52 Inactive
@sree-cfa sree-cfa merged commit 7be7726 into main Mar 5, 2024
5 checks passed
@sree-cfa sree-cfa deleted the axe-tests branch March 5, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cy-by cy-by cy-by approved these changes

Assignees

@sree-cfa sree-cfa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sree-cfa @cy-by