Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add child delete confirmation screen (design from ffsa) #80

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Add child delete confirmation screen (design from ffsa) #80

merged 2 commits into from
Feb 28, 2024

Conversation

cy-by
Copy link
Contributor

@cy-by cy-by commented Feb 27, 2024

🔗 Pivotal Tracker ticket

#186822601

✍️ Description

I wanted to get the subflow delete functionality working. We can update the design once we have it.

📷 What is looks like (same design as FFSA)

2024-02-27 at 16 41 42@2x

Add children-delete
c843b93 
- Not following a design
- Taking from form flow starter app delete confirmation
- Delete functionality is working
@enyia21 enyia21 self-requested a review February 28, 2024 16:46
sree-cfa
sree-cfa approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@sree-cfa sree-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - works as expected! Added one suggestion to make a note that this is a placeholder until we get designs

@enyia21 enyia21 temporarily deployed to il-gcc-add-child-confir-ragbij February 28, 2024 19:49 Inactive
enyia21
enyia21 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@enyia21 enyia21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything works as expected

@cy-by cy-by merged commit 6ec47a6 into main Feb 28, 2024
4 checks passed
@cy-by cy-by deleted the add-child-confirm-delete-186822601 branch February 28, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enyia21 enyia21 enyia21 approved these changes

@sree-cfa sree-cfa sree-cfa approved these changes

Assignees

@cy-by cy-by

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cy-by @enyia21 @sree-cfa